Fix 'linker' input unused warnings in Explicit Module Builds
#39509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nkcsgexi
approved these changes
Sep 29, 2021
|
@swift-ci please test Windows platform |
|
Build failed |
artemcm
force-pushed
the
FixExplicitPCMWarnings
branch
from
9cd9264 to
86958de
Compare
|
@swift-ci please test |
|
Build failed |
artemcm
force-pushed
the
FixExplicitPCMWarnings
branch
from
86958de to
50aea2f
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
|
@swift-ci please test windows platform |
|
Build failed |
It gets interpreted as just an executable we feed to the linker, since we launch `emit-pcm` actions via `swift-frontend` invocations, not `clang`.
…se-extra-clang-opts` is specified. Instead of *just* passing in `ExtraArgs`, we need to make sure to still form a command-line according to Clang's expectation.
artemcm
force-pushed
the
FixExplicitPCMWarnings
branch
from
50aea2f to
aa31794
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
=version of-working-directoryflag when passing it to clangUnder some circumstances this prevents the directory argument from being treated as an arbitrary path input.
Omit path to
clangfrom PCM build command-lineIt gets interpreted as just an executable we feed to the linker, since we launch
emit-pcmactions viaswift-frontendinvocations, notclang.Resolves rdar://83104047