Updated README.md Added Precise Swift Description #39536

calijoefornium · 2021-10-01T06:04:49Z

Added Precise Swift Description

finagolfin · 2021-10-01T06:58:37Z

README.md

+Swift makes it easy to write software that is incredibly fast and safe by design
+Swift is a powerful and intuitive programming language for iOS, iPadOS, macOS, tvOS, and watchOS.
+Writing Swift code is interactive and fun, the syntax is concise yet expressive, and Swift includes modern features developers love. 
+Swift code is safe by design, yet also produces software that runs lightning-fast.


This reads like an ad, is it really needed?

Hey @buttaface Thanks for reviewing I would like keep my point for your Query Asked

No it dosen't its just like providing some feature of Swift that is needed incase to understand advantages of swift over other Languages

finagolfin · 2021-10-01T08:58:37Z

Unless you have permission from the Swift project, you will not be able to test or merge.

@varungandhi-apple, perhaps you'd like to chime in.

finagolfin · 2021-10-01T09:44:33Z

You need someone with commit access to review, approve, and merge for you: take a look at the doc for how it works.

calijoefornium · 2021-10-01T10:09:10Z

You need someone with commit access to review, approve, and merge for you: take a look at the doc for how it works.

Can you mention or know someone who has commit access to review, approve, and merge access so it would help me as well

finagolfin · 2021-10-01T11:58:24Z

@benrimmington, you're one of the last people to modify this file, what do you think?

calijoefornium · 2021-10-01T12:23:04Z

@benrimmington, you're one of the last people to modify this file, what do you think?

@benrimmington can you help me out if possible

calijoefornium · 2021-10-02T02:13:41Z

@benrimmington, you're one of the last people to modify this file, what do you think?

@buttaface I think @benrimmington isn’t available or maybe inactive so @buttaface can you approve my pull request if possible

ejcheng

This reads like an ad, is it really needed?

@buttaface I would say you are right, the README seems to be a cozy way to welcome new users of Swift, and it is not supposed to be the beginning of a tutorial. The additions in this PR don't really fit well with the existing tone of the document.

calijoefornium · 2021-10-02T04:42:16Z

This reads like an ad, is it really needed?

@buttaface I would say you are right, the README seems to be a cozy way to welcome new users of Swift, and it is not supposed to be the beginning of a tutorial.

@import-brain thanks for reviewing I can change that but is my rest of content relatable??

ejcheng · 2021-10-02T04:45:31Z

This reads like an ad, is it really needed?

@buttaface I would say you are right, the README seems to be a cozy way to welcome new users of Swift, and it is not supposed to be the beginning of a tutorial.

@import-brain thanks for reviewing I can change that but is my rest of content relatable??

The content is great, I just personally don't believe that README would be the right place for it. Perhaps there's a tutorial doc somewhere in the repo? I can look further...

calijoefornium · 2021-10-02T04:46:32Z

@buttaface I would say you are right, the README seems to be a cozy way to welcome new users of Swift, and it is not supposed to be the beginning of a tutorial. The additions in this PR don't really fit well with the existing tone of the document.

@import-brain I have changed the heading if my rest of contents are good enough then can you approve my PR if possible ??

ejcheng · 2021-10-02T04:54:49Z

@buttaface I would say you are right, the README seems to be a cozy way to welcome new users of Swift, and it is not supposed to be the beginning of a tutorial. The additions in this PR don't really fit well with the existing tone of the document.

@import-brain I have changed the heading if my rest of contents are good enough then can you approve my PR if possible ??

@yashhchitroda approved, I'm not a maintainer, so I can't merge

calijoefornium · 2021-10-02T04:55:33Z

@import-brain Thanks for approving Can you guide me how can I merge my PR if possible

ejcheng · 2021-10-02T05:03:16Z

@import-brain Thanks for approving Can you guide me how can I merge my PR if possible

Sure! We do not have permissions to merge PRs in this repository, but we can ask other people who have permissions to do it, e.g. tbkka (not @'ing them because they get notifications every time they are mentioned). I'm not sure who the write access people are besides tbkka, but if you find out, you could mention (@) them here.

If one of the people who has merge access decides your PR is good, then they will merge it for you.

calijoefornium · 2021-10-03T04:14:20Z

Please Merge to main

@tbkka @DougGregor @slavapestov @jckarter @gottesmm
@lattner @jrose-apple @gribozavr @xedin @rjmccall
@practicalswift @aschwaighofer @eeckstein @compnerd
@nkcsgexi @rudkx @rintaro

finagolfin · 2021-10-03T06:57:13Z

@yashhchitroda, mentioning a bunch of unrelated names like that is not going to work and is more likely to get you added to their ignore lists.

What I did was check the commit history for this file, and then saw which of the recent authors showed recent activity on their github profile before pinging one person, Ben. He didn't respond, but it is now the weekend and this project is fairly quiet on weekends.

Also, marketing fluff like this in the doc is not a high priority, so obviously committers will put off reviewing pulls like this while they work on actual bug fixes or features. You might be waiting for weeks or months, and continually pinging people in the meantime is not going to endear you to them, ie you will make it take longer.

calijoefornium · 2021-10-03T07:30:50Z

@yashhchitroda, mentioning a bunch of unrelated names like that is not going to work and is more likely to get you added to their ignore lists.

What I did was check the commit history for this file, and then saw which of the recent authors showed recent activity on their github profile before pinging one person, Ben. He didn't respond, but it is now the weekend and this project is fairly quiet on weekends.

Also, marketing fluff like this in the doc is not a high priority, so obviously committers will put off reviewing pulls like this while they work on actual bug fixes or features. You might be waiting for weeks or months, and continually pinging people in the meantime is not going to endear you to them, ie you will make it take longer.

@buttaface First of all Thanks for Reaching me I highly appreciate your dedication and loyalty towards me as I am new to GitHub’s PR stuffs I wasn’t getting things merged so I was in an tense situation that might be due to some mistakes my comments won’t be sent to people who has Write access so I was continuously trying to keep them updated with respect to pull request but as you explain things now I am clear about the process

                                      -Thanks for reaching out

WowbaggersLiquidLunch · 2021-10-03T09:21:36Z

README.md

@@ -37,6 +37,12 @@ features like flow control, data structures, and functions, with high-level
 constructs like objects, protocols, closures, and generics. Swift embraces
 modules, eliminating the need for headers and the code duplication they entail.

+Announced in 2014, the Swift programming language has quickly become one of the fastest growing languages in history.
+Swift makes it easy to write software that is incredibly fast and safe by design
+Swift is a powerful and intuitive programming language for iOS, iPadOS, macOS, tvOS, and watchOS.


I think this line makes the description less precise, and furthers this misconception that it's a Apple/Darwin-only language.

The rest of the additions are already covered on the front page of swift.org.

@WowbaggersLiquidLunch thanks for reaching as you mentioned your point I support your point

but I don't think so it's less precise form anypoint of view, regarding swift.org well if it's in README it won't affect them either

I think this line makes the description less precise, and furthers this misconception that it's a Apple/Darwin-only language.

The rest of the additions are already covered on the front page of swift.org.

@WowbaggersLiquidLunch I concur with this, Swift can be used for a lot more than developing apps for Apple products.

I agree this isn't very good wording, is a great general purpose language and there is no need to highlight apple platforms at the exclusion of others like this.

WowbaggersLiquidLunch · 2021-10-03T09:25:30Z

README.md

@@ -25,7 +25,7 @@
 |**[Windows 2019 (VS 2017)](https://github.com/apple/swift-community-hosted-continuous-integration/blob/main/nodes/x86_64_windows_2019.json)** | x86_64 | [![Build Status](https://ci-external.swift.org/job/oss-swift-windows-x86_64/lastCompletedBuild/badge/icon)](https://ci-external.swift.org/job/oss-swift-windows-x86_64)|
 |**[Windows 2019 (VS 2019)](https://github.com/apple/swift-community-hosted-continuous-integration/blob/main/nodes/x86_64_windows_2019_VS2019.json)** | x86_64 | [![Build Status](https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/lastCompletedBuild/badge/icon)](https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019)|

-## Welcome to Swift
+## Welcome To Swift


The current capitalisation is correct. Propositions (unless at the start of sentence) are not capitalised in English titles: https://en.wikipedia.org/wiki/Title_case

Heading are always capatalized in order to grab users attraction

ktoso · 2021-10-04T02:03:37Z

Thanks for the effort but personally I don't feel this is really helping the readme much to be honest 🤔
It isn't clear how this would make it more compelling and welcoming to new and different users of the language.

calijoefornium · 2021-10-04T02:45:18Z

Thanks for the effort but personally I don't feel this is really helping the readme much to be honest thinking It isn't clear how this would make it more compelling and welcoming to new and different users of the language.

@ktoso Thanks for reaching me I don't think so maybe it will be helpful to some extent but anyways choice is up to you if you feel you can merge else close PR !!

ktoso · 2021-10-04T22:19:53Z

Thanks again @yashhchitroda, but this specific PR we don't feel is improving the readme's feel, so I'll close the PR.

Update README.md

2f8caf8

Added Precise Swift Description

finagolfin reviewed Oct 1, 2021

View reviewed changes

Update README.md

f78d87d

calijoefornium changed the title ~~Update README.md~~ Updated README.md Oct 2, 2021

ejcheng suggested changes Oct 2, 2021

View reviewed changes

Update README.md

e4f02e8

ejcheng approved these changes Oct 2, 2021

View reviewed changes

This was referenced Oct 2, 2021

Distributed actor isolation #39558

Merged

[android] Disable fake-toolchain-module-interface test #39547

Merged

calijoefornium changed the title ~~Updated README.md~~ Updated README.md Added Precise Swift Description Oct 2, 2021

WowbaggersLiquidLunch reviewed Oct 3, 2021

View reviewed changes

calijoefornium requested a review from WowbaggersLiquidLunch October 4, 2021 03:45

calijoefornium requested a review from ktoso October 4, 2021 03:45

ktoso closed this Oct 4, 2021

Updated README.md Added Precise Swift Description #39536

Updated README.md Added Precise Swift Description #39536

Uh oh!

Conversation

calijoefornium commented Oct 1, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

finagolfin commented Oct 1, 2021

Uh oh!

finagolfin commented Oct 1, 2021

Uh oh!

calijoefornium commented Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

finagolfin commented Oct 1, 2021

Uh oh!

calijoefornium commented Oct 1, 2021

Uh oh!

calijoefornium commented Oct 2, 2021

Uh oh!

ejcheng left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calijoefornium commented Oct 2, 2021

Uh oh!

ejcheng commented Oct 2, 2021

Uh oh!

calijoefornium commented Oct 2, 2021

Uh oh!

ejcheng commented Oct 2, 2021

Uh oh!

calijoefornium commented Oct 2, 2021

Uh oh!

ejcheng commented Oct 2, 2021

Uh oh!

calijoefornium commented Oct 3, 2021

Please Merge to main

Uh oh!

finagolfin commented Oct 3, 2021

Uh oh!

calijoefornium commented Oct 3, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ktoso commented Oct 4, 2021

Uh oh!

calijoefornium commented Oct 4, 2021

Uh oh!

ktoso commented Oct 4, 2021

Uh oh!

Uh oh!

calijoefornium commented Oct 1, 2021 •

edited

Loading

ejcheng left a comment •

edited

Loading