[5.5] Fix two false verification errors in the MemoryLifetimeVerifier #39537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
Build failed |
eeckstein
changed the title
…ity in SILType NFC
The MemoryLifetimeVerifier issued a false alarm if a tuple with a trivial enum-case (e.g. an Optional nil) is stored to a memory location. rdar://79781939
… empty tuple) like cases with no payloads.
eeckstein
force-pushed
the
fix-memory-lifetime-verifier-5.5
branch
from
2576887 to
0f2a7b7
Compare
|
@swift-ci test |
meg-gupta
approved these changes
Oct 4, 2021
tbkka
approved these changes
Oct 5, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle stores of tuples with trivial enums: the MemoryLifetimeVerifier issued a false alarm if a tuple with a trivial enum-case (e.g. an Optional nil) is stored to a memory location.
Treat enum cases with empty payloads (e.g. an empty tuple) like cases with no payloads.
rdar://79781939
This PR is a cherry pick of #38128 and #39200.