build: repair the build with VS2019 16.10.0 #39595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newest VS2019 release updates CMake to 3.20, which picks up `llvm-mt` as a preferred manifest tool. However, we do not build `llvm-mt` with libxml2 support currently, which prevents the use of the just built manifest tool for building libdispatch. Explicitly opt into using the MSVC manifest-tool. Cherry-pick 2990e8b (cherry picked from commit d4d4d13)
|
@swift-ci test |
Explicitly opt into the Microsoft manifest tool to be resilient against future CMake releases which prefer `llvm-mt` when building with clang (including clang-cl). This should ensure that we do not get broken with the update to VS2019 16.10 and CMake 3.20. (cherry picked from commit 3274984)
|
@swift-ci test windows |
|
@swift-ci test macOS |
|
@swift-ci test Linux |
shahmishal
deleted the
shahmishal/cherry-pick-d4d4d136a2c53cfe8828f85762c14def46ea5c99
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest VS2019 release updates CMake to 3.20, which picks up
llvm-mtas a preferred manifest tool. However, we do not buildllvm-mtwith libxml2 support currently, which prevents the use of thejust built manifest tool for building libdispatch. Explicitly opt into
using the MSVC manifest-tool.
Cherry-pick 2990e8b
(cherry picked from commit d4d4d13)