Skip to content

Add SWIFT_STDLIB_HAS_ENVIRON to remove usage of getenv/environ from stdlib #39599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2021
Merged

Add SWIFT_STDLIB_HAS_ENVIRON to remove usage of getenv/environ from stdlib #39599

merged 1 commit into from
Oct 12, 2021

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek kubamracek requested review from compnerd and mikeash October 5, 2021 22:39
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 6, 2021

Build failed
Swift Test OS X Platform
Git Sha - 7a0d329b56d7d397814c5bfb23d045c1757a2eb4

compnerd
compnerd requested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a very exciting change for windows - UAP doesn't allow environment, so this is definitely a useful thing.

stdlib/public/SwiftShims/LibcOverlayShims.h
@@ -63,6 +64,7 @@ static inline char * _Nullable *_swift_stdlib_getEnviron() {
return *_NSGetEnviron();
}
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I'm not sure why Windows is missing here...

@kubamracek kubamracek force-pushed the ifdef-out-environ branch 2 times, most recently from 8d72522 to fc444da Compare October 6, 2021 00:28
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 6, 2021

Build failed
Swift Test Linux Platform
Git Sha - fc444da221e65d084f0b9291623206a15069f8a8

@kubamracek
Copy link
Contributor Author

@swift-ci please test Linux platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@swift-ci
Copy link
Contributor

swift-ci commented Oct 6, 2021

Build failed
Swift Test Linux Platform
Git Sha - fc444da221e65d084f0b9291623206a15069f8a8

@kubamracek
Copy link
Contributor Author

@swift-ci please test Linux platform

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test

@swift-ci please test with toolchain and preset

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@swift-ci
Copy link
Contributor

swift-ci commented Oct 6, 2021

Build failed
Swift Test OS X Platform
Git Sha - fc444da221e65d084f0b9291623206a15069f8a8

@kubamracek kubamracek force-pushed the ifdef-out-environ branch 2 times, most recently from e3ce24f to b463b14 Compare October 7, 2021 16:20
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test

@swift-ci please test with toolchain and preset

@swift-ci
Copy link
Contributor

swift-ci commented Oct 7, 2021

Build failed
Swift Test OS X Platform
Git Sha - b463b1476fa002e891709f0b0a832ff29a4dce60

compnerd
compnerd requested changes Oct 7, 2021
View reviewed changes
@swift-ci
Copy link
Contributor

swift-ci commented Oct 7, 2021

Build failed
Swift Test Linux Platform
Git Sha - b463b1476fa002e891709f0b0a832ff29a4dce60

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

2 similar comments
@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

1 similar comment
@compnerd
Copy link
Member

compnerd commented Oct 8, 2021

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

6 similar comments
@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@kubamracek kubamracek merged commit c2c1bfb into swiftlang:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@mikeash mikeash Awaiting requested review from mikeash mikeash is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubamracek @swift-ci @compnerd