[Frontend] Don't ask to report bugs for a script failure #39619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://81233463
|
cc @lhames This is casting a wide net, differentiating compiler and script-side failures could be an interesting improvement in future JIT work. |
xymus
changed the title
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A script
crash.swiftfailing on an assert such as:Leads to a full stacktrace starting with a request to file a bug to swift.org:
This message is confusing as the issue here is an expected user-side script failure. Let's remove the "Please submit a bug report..." line in immediate mode and keep the stacktrace as it has useful information, even if likely too much for the need of the script developer. Note that this will apply to failures in both client code and in the compiler.
rdar://81233463