Skip to content

[Concurrency] Harden async_task_locals_copy_to_sync #39621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Oct 6, 2021

The test was a bit racy in that it was using a sleep for a bit to observe the printouts, those could perhaps be slower on a very slow machine, yielding a flaky test.

Replacement: use semaphores.

resolves rdar://83940885

@ktoso
Copy link
Contributor Author

ktoso commented Oct 6, 2021

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Oct 7, 2021

Unrelated Swift(windows-x86_64) :: SourceKit/CodeComplete/complete_member.swift

@ktoso ktoso merged commit d43fe18 into swiftlang:main Oct 7, 2021
@ktoso ktoso deleted the wip-harden-task-local-copy-test branch October 7, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant