RequirementMachine: Wire up protocol requirement signature minimization #39629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
rqm-protocol-signatures
branch
4 times, most recently
from
53bb17c to
c83d857
Compare
slavapestov
force-pushed
the
rqm-protocol-signatures
branch
from
c83d857 to
952f121
Compare
std::sort() will sometimes compare an element with itself (?) so remove the assert here. Duplicate conformance requirements should be already caught by checkGenericSignature() anyway.
When using the requirement machine to build protocol signatures, we can't get the protocol's dependencies by looking at the conformance requirements in it's requirement signature, because we haven't computed the requirement signature yet. Instead, get the dependencies via the recently-added getStructuralRequirements() request.
slavapestov
force-pushed
the
rqm-protocol-signatures
branch
from
952f121 to
16e1fdd
Compare
There are three settings, on, off and verify. Not hooked up quite yet.
…uirementMachineRequests.cpp
…minimizing protocol signatures Also while plumbing this through, don't record homotopy generators unless we're minimizing a protocol signature, since they're not used for anything else yet.
slavapestov
force-pushed
the
rqm-protocol-signatures
branch
from
16e1fdd to
8ab330a
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is controlled by the new
-requirement-machine-protocol-signatures=(on|off|verify)flag, which is just like-requirement-machine=(on|off|verify)for queries.It's still rather incomplete:
verifymode is not implemented yet.Indeed for now, it's only good for testing the homotopy reduction and generating conformances algorithms. Stay tuned!