Skip to content

Module aliasing: use module real name to create DIModule #39634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2021
Merged

Module aliasing: use module real name to create DIModule #39634

merged 2 commits into from
Oct 13, 2021

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Oct 7, 2021

Use module real name when creating DIModule, which can be different from the name if module aliasing is used. Resolves rdar://83967186.

@elsh elsh requested a review from adrian-prantl October 7, 2021 22:18
@elsh
Copy link
Contributor Author

elsh commented Oct 7, 2021

@swift-ci smoke test

adrian-prantl
adrian-prantl approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elsh
Copy link
Contributor Author

elsh commented Oct 12, 2021

@swift-ci smoke test

@elsh elsh merged commit 5277a76 into main Oct 13, 2021
@elsh elsh deleted the es-m5 branch October 13, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-prantl adrian-prantl adrian-prantl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsh @adrian-prantl