Skip to content

[cxx-interop] Fix a failing template import test for Windows #39643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2021
Merged

[cxx-interop] Fix a failing template import test for Windows #39643

merged 1 commit into from
Oct 9, 2021

Conversation

guitard0g
Copy link

For Windows, longs are Int32. These tests aren't concerned with that detail so this patch changes the test to use an int instead for simplicity.

@guitard0g guitard0g added the c++ interop Feature: Interoperability with C++ label Oct 8, 2021
@guitard0g guitard0g requested a review from zoecarver October 8, 2021 01:08
@guitard0g
Copy link
Author

@swift-ci please test

zoecarver
zoecarver approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@zoecarver
Copy link
Contributor

@swift-ci please test

@swift-ci smoke test and @swift-ci test will trigger the windows tests. The only one that wont is @swift-ci please smoke test _and merge_

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2021

Build failed
Swift Test OS X Platform
Git Sha - 49a6f10c927ee007c4464ebb4260082611cb12fc

@guitard0g
Copy link
Author

@swift-ci smoke test

@zoecarver
Copy link
Contributor

(Doing a full test to override the currently red bots.)

@swift-ci please test.

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2021

Build failed
Swift Test Linux Platform
Git Sha - 49a6f10c927ee007c4464ebb4260082611cb12fc

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2021

Build failed
Swift Test OS X Platform
Git Sha - 49a6f10c927ee007c4464ebb4260082611cb12fc

@guitard0g guitard0g force-pushed the fix-template-interop-test branch from 49a6f10 to 662ab11 Compare October 8, 2021 17:00
guitard0g
guitard0g commented Oct 8, 2021
View reviewed changes
@guitard0g
Copy link
Author

@swift-ci please test

@guitard0g guitard0g force-pushed the fix-template-interop-test branch from 662ab11 to 4758e65 Compare October 8, 2021 19:54
@guitard0g
Copy link
Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2021

Build failed
Swift Test OS X Platform
Git Sha - 4758e65

@compnerd
Copy link
Member

compnerd commented Oct 9, 2021

@swift-ci please test Windows platform

@compnerd
Copy link
Member

compnerd commented Oct 9, 2021

@swift-ci please test macOS platform

@compnerd
Copy link
Member

compnerd commented Oct 9, 2021

@swift-ci please test Windows platform

@compnerd compnerd merged commit 36d40b1 into swiftlang:main Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver zoecarver approved these changes

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guitard0g @zoecarver @swift-ci @compnerd