Clang Importer Diagnostics Pitch #39655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 8, 2021 12:56
Add infrastructure simplifying the passing of diagnostics and generation of stubs to replace unimported Clang nodes.
Add diagnostics reporting when any of the following unsupported types are using in a C function signature: - Atomic - Clang Matrix - Clang ExInt - Complex - OpenCL Pipe
Add diagnostics and a replacement stub on any C struct fields using any of the following unsupported types: - Atomic - Clang Matrix - Clang ExInt - Complex - OpenCL Pipe
NuriAmari
force-pushed
the
diagnostics-pitch
branch
from
78ae132 to
f0d2937
Compare
|
Work continued here: #39923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for improved diagnostics in the ClangImporter. Included in this diff are new diagnostics for unsupported C types when using in struct fields declarations, or function signatures.
This PR is meant for demonstration purposes and to accompany this pitch: https://forums.swift.org/t/pitch-improved-clangimporter-diagnostics/52687