[tests] Make some tests that are x86_64 hardcode that are failing on arm64 run with %target-cpu #39676
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arm64 run with %target-cpu
|
@swift-ci Please test |
|
@DougGregor friendly ping for a review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests are failing locally when running on arm64 machine basically with the same
error: could not find module '_Concurrency' for target 'x86_64-apple-macos'; found: arm64-apple-macos.So since none of them seems to be arch specific and are all restricted to macOS already, seems to be fine to run them with
%target-cpuI didn't know who to request for review, so all requests were GitHub suggested :)