Skip to content

[Concurrency] Limit queue width with set_width SPI call on linux #39732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Oct 14, 2021

I confirmed on my sample app that this avoids thread explosions beyond the expected "a few x of the core count" on Linux systems.

rdar://79907041

@ktoso
Copy link
Contributor Author

ktoso commented Oct 14, 2021

@swift-ci please smoke test Linux

@ktoso
Copy link
Contributor Author

ktoso commented Oct 14, 2021

@swift-ci please build toolchain Linux

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 4a0f50415657f683b0377a467413ebf96595c393

Install command
tar zxf swift-PR-39732-705-ubuntu16.04.tar.gz
More info

@ktoso ktoso requested a review from DougGregor October 14, 2021 12:01
@ktoso ktoso changed the title [WIP] Limit queue width with set_width call on linux as well [Concurrency] Limit queue width with set_width call on linux as well Oct 14, 2021
@ktoso
Copy link
Contributor Author

ktoso commented Oct 14, 2021

@swift-ci please smoke test macOS

@ktoso ktoso changed the title [Concurrency] Limit queue width with set_width call on linux as well [Concurrency] Limit queue width with set_width SPI call on linux Oct 14, 2021
@ktoso ktoso force-pushed the wip-limit-width-linux branch from 4a0f504 to 8578d22 Compare October 14, 2021 12:05
@ktoso
Copy link
Contributor Author

ktoso commented Oct 14, 2021

@swift-ci please smoke test

@DougGregor
Copy link
Member

Ah, I should have done this when I did the back-deployment change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants