🍒 5.5 [Concurrency] set queue width on all non-apple platforms, not just linux #39765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
changed the title
|
Build failed |
|
|
|
@swift-ci please test Linux |
|
@swift-ci please nominate |
compnerd
previously requested changes
Oct 16, 2021
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
|
Oh boy, thanks for the good catch @compnerd! |
|
@swift-ci please smoke test |
|
@swift-ci please test |
DougGregor
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We recently made setting the queue width also happen on linux; but rather, it should be for "non apple platforms" -- improving the condition based on John's feedback.
Risk: Low
Review by: @DougGregor @rjmccall
Testing: Ci testing
Original PR: #39764 and the previous one #39742
Radar: rdar://79907041