Skip to content

[Reflection] Fix ReflectionContext::allocationMetadataPointer. #39773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

[Reflection] Fix ReflectionContext::allocationMetadataPointer. #39773

merged 1 commit into from
Oct 29, 2021

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Oct 15, 2021

The definition of GenericMetadataCacheEntry was wrong, causing the function to return garbage.

@mikeash
[Reflection] Fix ReflectionContext::allocationMetadataPointer.
2e47543 
The definition of GenericMetadataCacheEntry was wrong, causing the function to return garbage.
@mikeash mikeash requested a review from aschwaighofer October 15, 2021 19:18
@mikeash
Copy link
Contributor Author

mikeash commented Oct 15, 2021

@swift-ci please smoke test

1 similar comment
@mikeash
Copy link
Contributor Author

mikeash commented Oct 28, 2021

@swift-ci please smoke test

aschwaighofer
aschwaighofer approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikeash mikeash merged commit 0950626 into swiftlang:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeash @aschwaighofer