Skip to content

Update maccatalyst 13.0 target minimum to 13.1 #39781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Oct 16, 2021

Clang enforces a minimum 13.1 deployment target. The driver, API
checker, and various tests assume 13.0 is a valid minimum. Update these
to reflect the actual 13.1 minimum.

Resolves rdar://84177900

'iosmac': 'x86_64-apple-ios13.0-macabi',
'iosmac': 'x86_64-apple-ios13.1-macabi',
Copy link
Contributor Author

@bnbarham bnbarham Oct 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this seem reasonable @nkcsgexi?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does. Thank you for the fix!

@bnbarham bnbarham requested a review from nkcsgexi October 16, 2021 01:01
Clang enforces a minimum 13.1 deployment target. The driver, API
checker, and various tests assume 13.0 is a valid minimum. Update these
to reflect the actual 13.1 minimum.

Resolves rdar://84177900
@bnbarham bnbarham changed the title [Test] Update targets using 13(.0)?-macabi to 13.1 Update maccatalyst 13.0 target minimum to 13.1 Oct 16, 2021
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

Corresponding updates in the swift-driver: swiftlang/swift-driver#879

@etcwilde
Copy link
Member

@swift-ci please test Windows platform

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnbarham bnbarham merged commit fbd3837 into swiftlang:main Oct 18, 2021
@bnbarham bnbarham deleted the 13-to-13.1-macabi branch October 18, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants