Skip to content

[LoopRotate] Use ownership for backedge block. #39783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Previously, all phi arguments added to the backedge block were given @owned ownership. That was not correct for arguments that needed to have @guaranteed ownership. Here, that is corrected by using the ownership of the original argument from the header block when adding the phi argument to the backedge block.

Previously, all phi arguments added to the backedge block were given
@owned ownership.  That was not correct for arguments that needed to
have @guaranteed ownership.  Here, that is corrected by using the
ownership of the original argument from the header block when adding the
phi argument to the backedge block.
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nate-chandler nate-chandler merged commit 008647c into swiftlang:main Oct 16, 2021
@nate-chandler nate-chandler deleted the loop-rotate/backedge-ownership branch October 16, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants