Add support for distributed functions in extensions of distributed actors #39785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors. Fix a few minor issues in the type checker and SILGen to properly cope with distributed functions defined within extensions of distributed actors. While here, centralize the logic that adds the "_remote_" function. Fixes rdar://84325525.
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
Distributed thunks were using the same mangling as direct method reference thunks (i.e., for "super" calls). Although not technically conflicting so long as actors never gain inheritance, it's confusing and could cause problems in the future. So, introduce a distinct mangling for distributed thunks and plumb them through the demangling and remangler.
|
@swift-ci please smoke test and merge |
ktoso
reviewed
Oct 16, 2021
| @@ -217,6 +217,7 @@ types where the metadata itself has unknown layout.) | |||
| global ::= global 'To' // swift-as-ObjC thunk | |||
| global ::= global 'TD' // dynamic dispatch thunk | |||
| global ::= global 'Td' // direct method reference thunk | |||
| global ::= global 'TE' // distributed actor thunk | |||
There was a problem hiding this comment.
okey E then! Thanks for spotting this
There was a problem hiding this comment.
Hmmm we also used the Td in:
case Kind::DistributedThunkAsyncFunctionPointer: {
std::string Result = getSILDeclRef().mangle();
Result.append("Td");
Result.append("Tu");
return Result;
}
which this doesnt fix yet -- i think there we also need to use TE right? I'll follow up with this.
There was a problem hiding this comment.
Yup, and that's what failed the tests -- I fixed it :)
ktoso
approved these changes
Oct 16, 2021
|
@swift-ci please build toolchain macOS |
|
Actual failure, I think I know how to solve -- on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few minor issues in the type checker and SILGen to properly cope with
distributed functions defined within extensions of distributed actors.
While here, centralize the logic that adds the "remote" function.
... and since this uncovered a problem with the mangling for distributed
functions, fix that, too.
Fixes rdar://84325525.