Skip to content

Remove unnecessary import statement #39786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Remove unnecessary import statement #39786

merged 2 commits into from
Nov 6, 2021

Conversation

tokizuoh
Copy link

What's in this pull request?

Removed Foundation import statement when UIKit and Foundation were imported.
Because UIKit includes Foundation.

1

@tokizuoh
Copy link
Author

@swift-ci Please smoke test

@tokizuoh
Copy link
Author

Users with commit access can trigger pull request testing by writing a comment on a PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment used. The current test types are:
https://github.com/apple/swift/blob/main/docs/ContinuousIntegration.md#swift-ci

sorry, CI doesn't work because I don't have the right to commit.
I will wait.

@CodaFi
Copy link
Contributor

CodaFi commented Nov 4, 2021

Sorry for letting this sit by the wayside

@swift-ci smoke test and merge

@CodaFi
Copy link
Contributor

CodaFi commented Nov 5, 2021

@swift-ci smoke test Linux

@tokizuoh
Copy link
Author

tokizuoh commented Nov 6, 2021

@CodaFi
Thank you for moving the CI!
It seems that "Test and Merge (smoke test)" is failing.

Jenkins log

/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift-docc/Tests/SwiftDocCUtilitiesTests/PreviewServer/PreviewServerTests.swift:180: error: PreviewServerTests.testConcurrentRequests : XCTAssertEqual failed: ("nil") is not equal to ("Optional("fonts content")") - 
11:06:07 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift-docc/Tests/SwiftDocCUtilitiesTests/PreviewServer/PreviewServerTests.swift:178: error: PreviewServerTests.testConcurrentRequests : XCTAssertEqual failed: ("0") is not equal to ("200") - 
11:06:07 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift-docc/Tests/SwiftDocCUtilitiesTests/PreviewServer/PreviewServerTests.swift:181: error: PreviewServerTests.testConcurrentRequests : XCTAssertNoThrow failed: threw error "unixDomainSocketPathTooLong" - 
11:06:07 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift-docc/Tests/SwiftDocCUtilitiesTests/PreviewServer/PreviewServerTests.swift:180: error: PreviewServerTests.testConcurrentRequests : XCTAssertNoThrow failed: threw error "unixDomainSocketPathTooLong" - 
11:06:07 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift-docc/Tests/SwiftDocCUtilitiesTests/PreviewServer/PreviewServerTests.swift:181: error: PreviewServerTests.testConcurrentRequests : XCTAssertEqual failed: ("0") is not equal to ("404") - 
11:06:07 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift-docc/Tests/SwiftDocCUtilitiesTests/PreviewServer/PreviewServerTests.swift:180: error: PreviewServerTests.testConcurrentRequests : XCTAssertEqual failed: ("nil") is not equal to ("Optional("fonts content")") - 
11:06:07 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift-docc/Tests/SwiftDocCUtilitiesTests/PreviewServer/PreviewServerTests.swift:178: error: PreviewServerTests.testConcurrentRequests : XCTAssertEqual failed: ("0") is not equal to ("200") - 
11:06:07 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift-docc/Tests/SwiftDocCUtilitiesTests/PreviewServer/PreviewServerTests.swift:177: error: PreviewServerTests.testConcurrentRequests : XCTAssertNoThrow failed: threw error "unixDomainSocketPathTooLong" - 
// and more...

It looks like there are errors that are not affected by this PR.

What action should I take?
Thank you as always.

@CodaFi
Copy link
Contributor

CodaFi commented Nov 6, 2021

Agreed. Thanks for the PR.

@CodaFi CodaFi merged commit 8315e8e into swiftlang:main Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants