Don't emit marker protocols into runtime type metadata. #39812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marker protocols don't exist at runtime, drop them when mangling a type for the purposes of runtime type metadata or reflection. Fixes rdar://82314404. (cherry picked from commit 7d7ec9e)
|
@swift-ci please test |
|
@swift-ci please nominate |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
airspeedswift
approved these changes
Oct 22, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Marker protocols like
Sendabledon't exist at runtime, but the compiler is mangling them into the strings that appear in runtime metadata, leading to miscompiles and broken mirror and tool support when there are properties and generics with typeSendable. Drop marker protocols when mangling a type for the purposes of runtime type metadata or reflection.Risk: Low
**Reviewed by: ** Joe Groff
Testing: PR testing, CI, new tests
Original PR: #39782
Radar: rdar://82314404