Skip to content

[5.5]Sema: allow @_originallyDefinedIn to specify identical version numbers as @available. #39815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Oct 19, 2021

Description: We used to require @_originallyDefinedIn to specify strictly greater version numbers than @available attributes. However, this seems to block a use case where we only use the original module name for mangling while skipping emitting linker directives as $ld$previous.
Risk: Very Low
Testing: PR testing, CI, new tests
Original PR: #39813
Radar: rdar://84425205

@nkcsgexi nkcsgexi requested a review from a team as a code owner October 19, 2021 21:07
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@nkcsgexi nkcsgexi requested a review from xymus October 19, 2021 21:16
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nkcsgexi nkcsgexi merged commit 33b5a48 into swiftlang:release/5.5 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants