Skip to content

Fix the alignment of future fragments for highly-aligned result types #39829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fix the alignment of future fragments for highly-aligned result types #39829

merged 2 commits into from
Oct 20, 2021

Conversation

rjmccall
Copy link
Contributor

Fixes rdar://82097325

@rjmccall
Copy link
Contributor Author

@swift-ci Please test

This was referenced Oct 20, 2021
Closed
Merged
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 869e3c2d0b7b7dca0d70019d03f024366bf92be5

@aschwaighofer
Copy link
Contributor

Good that you added that assert. Looks like we might need some ‘alignto’ s in the headerOffset computation.

@aschwaighofer
Copy link
Contributor

Oh wait shouldn’t that assert be “address &(alignof(type)-1)==0”

@rjmccall rjmccall force-pushed the fix_alignment_future_fragment branch from 869e3c2 to d7cae26 Compare October 20, 2021 17:11
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - d7cae26

aschwaighofer
aschwaighofer approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmccall
Copy link
Contributor Author

Oh wait shouldn’t that assert be “address &(alignof(type)-1)==0”

Yeah, hazards of late-night patches :)

@rjmccall
Copy link
Contributor Author

@swift-ci Please clean test Linux

@DougGregor
Copy link
Member

@swift-ci please clean test Linux

@rjmccall rjmccall merged commit a64564f into swiftlang:main Oct 20, 2021
@rjmccall rjmccall deleted the fix_alignment_future_fragment branch October 20, 2021 22:34
@fassko fassko mentioned this pull request Oct 27, 2021
Closed
@DougGregor DougGregor mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjmccall @swift-ci @aschwaighofer @DougGregor