[Mem2Reg] RAUW undef lexical lifetime phis. #39839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if it was determined that a proactive phi was unnecessary, it was removed, along with the phis for the lifetime and the original value of which the proactive phi was a copy. The uses of only one of the three phis (namely, the proactive phi) was RAUW undef. In the case where the only usage of the phi was to branch back to the block that took the phi as an argument, that was a problem. Here, that is fixed by giving all three phis the same treatment. To avoid duplicating code, that treatment is pulled out into a new lambda. This was exposed by adding lifetime versions of some OSSA versions of mem2reg tests that had been missed previously.
|
@swift-ci please test |
|
@swift-ci please clean test windows platform |
nate-chandler
deleted the
lexical_lifetimes/rauw-all-three-phis-if-proactive-phi-is-unnecessary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if it was determined that a proactive phi was unnecessary, it was removed, along with the phis for the lifetime and the original value of which the proactive phi was a copy. The uses of only one of the three phis (namely, the proactive phi) was RAUW undef. In the case where the only usage of the phi was to branch back to the block that took the phi as an argument, that was a problem. Here, that is fixed by giving all three phis the same treatment. To avoid duplicating code, that treatment is pulled out into a new lambda.
This was exposed by adding lifetime versions of some OSSA versions of mem2reg tests that had been missed previously.