ABI Checker: include mangled names in ABI descriptor files #39846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
DougGregor
approved these changes
Oct 20, 2021
| } else if (auto Dtor = dyn_cast<DestructorDecl>(VD)) { | ||
| return Ctx.buffer(NewMangler.mangleDestructorEntity(Dtor, false)); | ||
| } else if (auto TD = dyn_cast<TypeDecl>(VD)) { | ||
| return Ctx.buffer(NewMangler.mangleLocalTypeDecl(TD)); |
There was a problem hiding this comment.
Not all types are local types, should we do the "local type" check here?
There was a problem hiding this comment.
Good point! I've refactored this function into ASTMangler so we could cover all types.
|
@swift-ci please smoke test |
Previously, we use USR as a delegate for mangled name. However, USR won't incorporate name changes made by attributes like @_silgen_name. Instead, we should add a dedicated field for canonical mangled names. rdar://84202064
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using USR as a delegate for mangled names. However, USR won't incorporate name changes made
by attributes like @_silgen_name. Instead, we should add a dedicated field for mangled names.
rdar://84202064