Infer 'isolated' closure parameters from context. #39850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a closure is provided with a contextual type that has isolated parameters, infer that the corresponding closure parameter is "isolated". Fixes rdar://83732479.
|
@swift-ci please smoke test |
xedin
reviewed
Oct 21, 2021
|
@swift-ci please smoke test |
ktoso
approved these changes
Oct 21, 2021
|
Windows failures is a Swift frontend crash in a test that shouldn't have mattered. Hmm. Trying again |
|
@swift-ci please test Windows |
Yes, but also you could have multiple closures that have isolated parameters. |
xedin
approved these changes
Oct 21, 2021
lib/Sema/CSSolver.cpp
Outdated
| @@ -186,6 +186,8 @@ Solution ConstraintSystem::finalize() { | |||
|
|
|||
| solution.solutionApplicationTargets = solutionApplicationTargets; | |||
| solution.caseLabelItems = caseLabelItems; | |||
| solution.isolatedParams.clear(); | |||
There was a problem hiding this comment.
Nit: I don't think we need a to clear here because it's a brand new solution allocated by finalize.
There was a problem hiding this comment.
Sure, I'll drop it in a follow-up commit
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a closure is provided with a contextual type that has isolated
parameters, infer that the corresponding closure parameter is "isolated".
Fixes rdar://83732479.