[Driver][SymbolGraph] add new flag -symbol-graph-minimum-access-level #39865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please build toolchain macOS platform |
|
@swift-ci Please smoke test macOS platform |
|
@swift-ci Please build toolchain macOS platform |
|
Gonna retry the test in case that one error was a fluke with a stale cache... @swift-ci Please smoke test macOS platform |
|
@swift-ci Please build toolchain macOS platform |
|
Using swiftlang/swift-driver#890 @swift-ci Please smoke test |
|
Using swiftlang/swift-driver#890 @swift-ci Please build toolchain macOS platform |
|
macOS Toolchain Install command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://79099869
When generating a symbol graph, it's sometimes useful to include information for non-public symbols. However, symbol graphs generating during a compile were always forced to a "minimum access level" of "public". The only option was to run
swift-symbolgraph-extractafter the fact and use its-minimum-access-levelflag. This PR adds a new flag to the driver,-symbol-graph-minimum-access-level, that allows users to specify access levels other than "public" when generating symbol graphs during a compile.I also took the opportunity to strip out the symbol-graph-specific fields from
SerializationOptions, in favor of pulling theSymbolGraphOptionsdirectly from theCompilerInvocationthat parses them from the args. (I added those args back in #38070, but didn't connect them all the way down to where they were used in theserialize()function. Here, i finished the job.)