Skip to content

Revert "Reapply "ABI Checker: include mangled names in ABI descriptor files"" #39879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Reapply "ABI Checker: include mangled names in ABI descriptor files"" #39879

wants to merge 1 commit into from

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Oct 22, 2021

Reverts #39855

@artemcm artemcm requested a review from nkcsgexi October 22, 2021 17:49
@artemcm
Copy link
Contributor Author

artemcm commented Oct 22, 2021

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor

Please don't revert this. The newly detected breakages are false positives due to the stale baselines that don't respect @_silgen_name. cc: @lorentey

@artemcm
Copy link
Contributor Author

artemcm commented Oct 22, 2021

Will update the failing test's expected output instead.

@artemcm artemcm closed this Oct 22, 2021
@shahmishal shahmishal deleted the revert-39855-84202064-reapply branch May 13, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemcm @nkcsgexi