[test] Enable some language features in validation-test lit config #39881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porglezomp
changed the title
|
@swift-ci please test |
DougGregor
approved these changes
Oct 22, 2021
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
The validation-test suite was incorrectly being run without the concurrency feature enabled, so the tests were disabled. Now that they're running, they need fixed availability annotations.
The logic in test/lit.site.cfg.in and validation-test/lit.site.cfg.in is largely duplicated. This adds some of the missing features in order to try to fix backdeployconcurrency testing. This should be more fundamentally fixed to keep the different test configs in sync.
porglezomp
force-pushed
the
upload-dylibs-concurrency-back-deploy
branch
from
76245b0 to
c59b238
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in
test/lit.site.cfg.inandvalidation-test/lit.site.cfg.inis largely duplicated.This adds some of the missing features in order to try to fix backdeployconcurrency testing.
This should be more fundamentally fixed to keep the different test configs in sync.