Temporarily disable distributed_actor_init_local.swift test because it's flaky #39894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
LGTM.
FYI @kavon
It seems those two:
// TODO: it's not obvious why the resigns happen later for the async ones.
// might need to find a way to force the deallocation at a specific point,
// or just use check-dag or something.
// CHECK: resign id:AnyActorIdentity(ActorAddress(address: "[[ID]]"))
// CHECK: resign id:AnyActorIdentity(ActorAddress(address: "[[ID]]"))
don't actually happen always? So there's definitely something off with the deinits.
The error happens pretty rarely:
/Users/ktoso/code/swift-project/swift/test/Distributed/Runtime/distributed_actor_init_local.swift:147:12: error: CHECK: expected string not found in input
// CHECK: resign id:AnyActorIdentity(ActorAddress(address: "[[ID]]"))
^
<stdin>:18:57: note: scanning from here
resign id:AnyActorIdentity(ActorAddress(address: "xxx"))
^
<stdin>:18:57: note: with "ID" equal to "xxx"
resign id:AnyActorIdentity(ActorAddress(address: "xxx"))
^
Input file: <stdin>
Check file: /Users/ktoso/code/swift-project/swift/test/Distributed/Runtime/distributed_actor_init_local.swift
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
13: assign type:PickATransport2, id:ActorAddress(address: "xxx")
14: ready actor:main.PickATransport2, id:AnyActorIdentity(ActorAddress(address: "xxx"))
15: assign type:Bug_CallsReadyTwice, id:ActorAddress(address: "xxx")
16: ready actor:main.Bug_CallsReadyTwice, id:AnyActorIdentity(ActorAddress(address: "xxx"))
17: ready actor:main.Bug_CallsReadyTwice, id:AnyActorIdentity(ActorAddress(address: "xxx"))
18: resign id:AnyActorIdentity(ActorAddress(address: "xxx"))
check:147'0 X error: no match found
check:147'1 with "ID" equal to "xxx"
kubamracek
force-pushed
the
disable-distributed_actor_init_local.swift
branch
from
9fdc2c8 to
3799f4c
Compare
|
@swift-ci please smoke test |
|
Windows failure was:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.