[Stdlib] Enable -Wformat-nonliteral and make it an error. #39901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
mikeash
approved these changes
Oct 25, 2021
Turn on -Wformat-nonliteral so that any format string that is passed through a variable is turned into an error. There are a variety of reasonable ways of fixing these where they occur, and it's safer to have this switched on. rdar://84571859
al45tair
force-pushed
the
problem/84571859-2
branch
from
4dbd93e to
b5b702e
Compare
|
@swift-ci Please smoke test |
|
(I just rebased it to make sure that we only end up with the enabling change in this PR, in case we need to revert.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on
-Wformat-nonliteralso that any format string that is passed through a variable is turned into an error. There are a variety of reasonable ways of fixing these where they occur, and it's safer to have this switched on.This should only be merged after #39900.
rdar://84571859