Skip to content

test: update stability-stdlib-abi-with{out}-asserts.test #39904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Oct 25, 2021

These new entries are false positives due to stale baselines that didn't record @_silgen_name.

@artemcm artemcm requested review from lorentey and nkcsgexi October 25, 2021 17:18
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

These new entries are false positives due to stale baselines that didn't record @_silgen_name.
@artemcm artemcm force-pushed the FixABIStabilitytest branch from ef9206e to a29f521 Compare October 25, 2021 17:31
@artemcm artemcm changed the title test: update stability-stdlib-abi-with-asserts.test test: update stability-stdlib-abi-with{out}-asserts.test Oct 25, 2021
@artemcm artemcm merged commit 8b34fca into swiftlang:main Oct 25, 2021
@lorentey
Copy link
Member

The without-asserts file is included in the asserts one, so adding expected changes to both files will trigger failures in test runs with assertions enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants