[moveOnly] Add an @_noImplicitCopy decl attribute and allow it to be only attached to local lets. #39927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only attached to local lets. Some notes: 1. This is not actually wired up to any part of codegen. Instead, this PR just has the code necessary to parse the attribute and to ensure that we use it only on local lets. The rest will come in subsequent commits. 2. I am allowing for the attribute to be attached to generic things in Sema since we do not have enough information in the TypeChecker to distinguish in between structs with a type parameter but that have all non-generic stored vars from one with generic stored vars. We can only support the later with opaque values but the former we can support without opaque values (and is one of the use cases we are interested in). rdar://83957088
|
@swift-ci smoke test |
DougGregor
reviewed
Oct 26, 2021
|
|
||
| if (vd->hasStorage()) { | ||
| // We do not support fields of nominal types now. | ||
| if (isa<NominalTypeDecl>(dc)) { |
There was a problem hiding this comment.
I think you want !dc->isLocalContext() here. It should be able to subsume this check and the one below as well. (You'll likely want a separate check for static).
There was a problem hiding this comment.
Ok. I'll do that in a subsequent PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
This is not actually wired up to any part of codegen. Instead, this PR just
has the code necessary to parse the attribute and to ensure that we use it only
on local lets. The rest will come in subsequent commits.
I am allowing for the attribute to be attached to generic things in Sema
since we do not have enough information in the TypeChecker to distinguish in
between structs with a type parameter but that have all non-generic stored vars
from one with generic stored vars. We can only support the later with opaque
values but the former we can support without opaque values (and is one of the
use cases we are interested in).
rdar://83957088
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.