Skip to content

Fix embedded plist of back-deployed concurrency library #39934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2021
Merged

Fix embedded plist of back-deployed concurrency library #39934

merged 3 commits into from
Oct 27, 2021

Conversation

DougGregor
Copy link
Member

Fix two issues with the embedded plist for the back-deployed concurrency library:

  • Remove underscores from CFBundleIdentifier of libraries, because they're not permitted in the reverse-DNS name there.
  • Propagate Swift version information to the back-deployed binaries, because it's better than leaving it empty.

Fixes rdar://84645973.

@DougGregor DougGregor requested a review from a team as a code owner October 27, 2021 04:01
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit 4f6c023 into swiftlang:release/5.5 Oct 27, 2021
@DougGregor DougGregor deleted the back-deploy-fix-bundle-identifier-5.5 branch October 27, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkremenek tkremenek tkremenek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @tkremenek