Skip to content

Remove repetitive wording. #39979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Conversation

amartini51
Copy link
Member

Fixes rdar://59618453

Fixes <rdar://59618453>
@amartini51 amartini51 requested a review from gottesmm October 29, 2021 18:06
@amartini51
Copy link
Member Author

@gottesmm I'm not 100% sure of the last piece of this change — do you use ManagedBufferPointer in addition to, or instead of ManagedBuffer when multiple classes are being used for storage?

@gottesmm
Copy link
Contributor

gottesmm commented Nov 4, 2021

@amartini51 I am not the person to review this change. I would ask one of the stdlib folks. I think that @lorentey would be a good one.

@amartini51 amartini51 requested a review from lorentey November 4, 2021 22:16
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lorentey
Copy link
Member

lorentey commented Nov 4, 2021

@swift-ci smoke test

@amartini51
Copy link
Member Author

@gottesmm Thanks. Looks like I can't remove you as a reviewer, but you can "dismiss" the request to review.

@lorentey I'm not 100% sure of the last piece of this change — do you use ManagedBufferPointer in addition to, or instead of ManagedBuffer when multiple classes are being used for storage?

@lorentey
Copy link
Member

lorentey commented Nov 4, 2021

Ah -- ManagedBufferPointer does support wrapping classes that aren't ManagedBuffer subclasses, although this isn't exercised very often. (The big limitation is that such a class must have no stored properties.)

(One use case for this is having all empty instances of a generic container type use the same type-punned empty singleton storage, no matter what the Element type is.)

@CodaFi
Copy link
Contributor

CodaFi commented Nov 5, 2021

@swift-ci smoke test Linux platform

@CodaFi CodaFi merged commit ad0a5bf into swiftlang:main Nov 6, 2021
@amartini51 amartini51 deleted the managed_buffer_59618453 branch December 8, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants