GSB: Perform conditional requirement inference in AbstractGenericSignatureRequest too #39983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to assert if a generic requirement of a signature could
be proved from the signature with the requirement removed.
However, in some rare cases minimization can *add* new requirements
as well as remove them.
This is going to come up even more with the RequirementMachine,
where for example the following signature is accepted:
protocol Q { associatedtype A : P }
protocol P { associatedtype B }
<T where T.A : Q, T.A.B == T>
and minimized as follows:
<T where T : P, T.A : Q, T.A.B == T>
…atureRequest too There's no way to trigger this from a test right now; it's for some changes @jckarter is working on.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.