[Result Builders] Correct type witness substitution when computing inferred result builder attributes from protocol requirements. #39988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferred result builder attributes from protocol requirements.
…itnesses, always map type parameters into context. For result builders applied to function/variable/subscript bodies, the builder type will only be used for calls to `buildBlock` and friends inside the body, for which we always want the contextual type of the builder, not the interface type.
slavapestov
approved these changes
Oct 30, 2021
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few bugs when inferring a result builder attribute on a value witness from the protocol requirement:
Selfand associated types inside result builder attributes.buildBlockand friends in the body.Resolves: rdar://84818325