[stdlib] Adopt availability macros #39994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
Fascinating. This feels unrelated, but it's also not been happening outside of this PR. |
|
@swift-ci test macOS platform |
xymus
reviewed
Nov 1, 2021
| @@ -1632,6 +1632,9 @@ Parser::parseAvailabilityMacro(SmallVectorImpl<AvailabilitySpec *> &Specs) { | |||
| if (NameMatch == Map.end()) | |||
| return makeParserSuccess(); // No match, it could be a standard platform. | |||
|
|
|||
| SyntaxParsingContext VersionRestrictionContext( | |||
| SyntaxContext, SyntaxKind::AvailabilityVersionRestriction); | |||
|
|
|||
There was a problem hiding this comment.
What does this do in practice here?
There was a problem hiding this comment.
I have no idea what I'm doing, but it feels like these parsing contexts associate parsed entities with information about the specific grammar rule that was used to parse them (or rather, the underlying syntactic role).
This particular one lets Syntax know that SwiftStdlib 5.3 has the same syntactic role as iOS 12.4. Otherwise these entities (along with the entire decl the attribute appears on) get classified as unknown, which breaks things (incl. -verify-syntax-tree). (Perhaps these macros should have their own role, but I don't know enough to say for sure (c.f. 84827672).)
Cc @akyrtzi to tell me how terribly wrong I am. 😉
There was a problem hiding this comment.
Interesting I missed this in the past and now I see where this is defined for the classic platform availability. Thanks for fixing it!
xymus
approved these changes
Nov 1, 2021
|
[SR-15708] [stdlib] Availability macros aren't defined for Linux? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the stdlib codebase, replace explicit platform availability incantations of the form
macOS x.y, iOS x.y, watchOS x.y, tvOS x.ywith the availability macros defined in PR #39962.Unfortunately availability macros do not currently work in
if #availablestatements in inlinable function bodies, so leave those in place for now, adding a comment specifying the intended macro. (Fixing this isn't trivial, as it requires transforming code emitted into .swiftinterface files, and we aren't set up for that yet.)