-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Buildfix getting stack bounds on OpenBSD. #39995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @grynspan |
FTR, the buildbreak was in Stubs.cpp in #37666. |
83c4f40
to
4189bab
Compare
OpenBSD doesn't have `pthread_attr_get_np` and expects something like `pthread_attr_getstackaddr` to be used to get the initial stack size. We need to use `pthread_stackseg_np` on this platform to get the stack size and location of `pthread_self`.
4189bab
to
b5135fa
Compare
@swift-ci please test |
Please note swift-ci does not run tests on OpenBSD and it's not a platform actively supported by the Swift team at this time. Can you confirm:
|
Correct. (I made an earlier comment about a little confused about which pointer should be which in this stub, but I deleted it since think I've sorted it out now.)
There are a number of other unrelated issues that are currently preventing some of the automated tests from running that I need to debug and fix. However, I can extract the actual test executable build commands from I can't find a |
Those tests are located in utils/run-test --lit ../llvm-project/llvm/utils/lit/lit.py \
../build/Ninja-RelWithDebInfoAssert/swift-macosx-$(uname -m)/test-macosx-$(uname -m) \
--filter="temporary_allocation" I'm not certain how to modify that command to work on OpenBSD (I imagine just replacing |
Got it. Both |
Build failed |
Test failures appear unrelated. |
Build failed |
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
OpenBSD doesn't have
pthread_attr_get_np
and expects something likepthread_attr_getstackaddr
to be used to get the initial stack size.We need to use
pthread_stackseg_np
on this platform to get thestack size and location of
pthread_self
.