[swift-stdlib-tool] Add support for back deployed concurrency #39996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tool was mostly already compatible with copying `libswift_Concurrency.dylib` based on whether or not the executables it was scanning linked it. The only thing missing was that it can now end up copying from different source directories, the older `swift-5.0` directory, and the new `swift-5.5` directory. This change allows users to pass `--source-libraries` multiple times (or picks a default with both) in order to have it scan both directories for any libraries the app links. The biggest part of this change is instead of storing just the library name throughout this logic we now store the actual discovered path, so that we don't have to loop through all potential source directories each time we need to find the library, only the first time.
|
Unlike Xcode's internal implementation of this I didn't put this behind another flag (depending on if folks are using the default |
|
FYI @DougGregor @allevato |
|
@swift-ci please test |
allevato
reviewed
Nov 1, 2021
|
@swift-ci please smoke test |
DougGregor
approved these changes
Nov 2, 2021
|
thanks! once this lands I'll submit a cherry pick for 5.5 |
|
⛵ |
keith
deleted the
ks/swift-stdlib-tool-add-support-for-back-deployed-concurrency
branch
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool was mostly already compatible with copying
libswift_Concurrency.dylibbased on whether or not the executables itwas scanning linked it. The only thing missing was that it can now end
up copying from different source directories, the older
swift-5.0directory, and the new
swift-5.5directory.This change allows users to pass
--source-librariesmultiple times(or picks a default with both) in order to have it scan both directories
for any libraries the app links. The biggest part of this change is
instead of storing just the library name throughout this logic we now
store the actual discovered path, so that we don't have to loop through
all potential source directories each time we need to find the library,
only the first time.
https://forums.swift.org/t/swift-concurrency-back-deployment/51908/36