Fix OSSA Outliner for scoped guaranteed values #40002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eir new uses in the outlined call
|
@swift-ci test |
|
Build failed |
|
@swift-ci test Linux platform |
|
@swift-ci test and merge |
|
@swift-ci clean test linux platform |
|
Build failed |
|
@swift-ci clean test linux platform |
|
@swift-ci test macOS platform |
|
@swift-ci test windows platform |
|
Build failed |
|
@swift-ci test macOS platform |
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While outlining, the new uses of scoped guaranteed values maybe beyond the lifetime ends. For this reason use the new api
makeGuaranteedValueAvailablewhich is built on top ofOwnershipLifetimeExtenderto create new guaranteed values that are correctly scoped and use as arg for the outlined call.This ends up creating
copy_value+borrow_valuethat are additional to the non-OSSA outliner. WhenCopyPropagationwith lexical lifetimes are enabled, these additional instructions will be removed to get performance parity with the non-OSSA Outliner.