Skip to content

Re-enable a test requiring an optimized stdlib to ensure we pattern match. #40005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Nov 1, 2021

rdar://84780237

@gottesmm gottesmm requested a review from etcwilde November 1, 2021 22:49
@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 1, 2021

@swift-ci smoke test

@etcwilde
Copy link
Member

etcwilde commented Nov 1, 2021

@swift-ci please test macOS platform

@etcwilde
Copy link
Member

etcwilde commented Nov 3, 2021

Do we want to ensure the behaviour of debug code as well, or are we not expecting move-only to work with debug builds?

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 9, 2021

@etcwilde the issue is that the _move builtin itself isn't being optimized enough. So the problem isn't an issue as long as we don't use the builtin in the stdlib since all over code should use a release stdlib. That may need to change with time though.

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly concerned that the optimization level used to build the stdlib effects how client code is emitted since that sounds like grounds for ABI issues later down the line, but I'm approving so we can get the testing turned back on here.

@gottesmm gottesmm merged commit 487b16a into swiftlang:main Jan 11, 2022
@gottesmm gottesmm deleted the pr-596b3ad22fdb5e2e847eef3e843e8e7023c14230 branch January 11, 2022 19:58
@compnerd
Copy link
Member

This seems to be failing consistently on the builders now? https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/7621/console

@etcwilde
Copy link
Member

Yeah, this probably should have been re-tested before merging.

@compnerd
Copy link
Member

Seems to be failing on Linux as well: https://ci.swift.org/job/swift-PR-Linux-smoke-test/32054/console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants