Always weak-link symbols from the concurrency library when back-deploying #40007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying This allows applications that back-deploy but only use concurrency in newer code to load and execute properly, even when the concurrency library is not available. Fixes rdar://84877644.
|
@swift-ci please test |
|
Looks good, now to figure out why my computer is still making |
|
Build failed |
|
@swift-ci please clean test linux platform |
|
Linux errors were all issues with the compiled module being created by an older version of the compiler and being unable to import |
etcwilde
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Did a complete clean rebuild and now things are working. I've verified by inspecting the IR in addition to generating a binary and running nm -um against it.
(undefined) weak external _$sScP8rawValues5UInt8Vvg (from libswift_Concurrency)
(undefined) weak external _$sScPMa (from libswift_Concurrency)
(undefined) weak external _$sScPMn (from libswift_Concurrency)
(undefined) weak external _$sScTss5NeverORs_rlE5valuexvg (from libswift_Concurrency)
(undefined) weak external _$sScTss5NeverORs_rlE5valuexvgTu (from libswift_Concurrency)
(undefined) weak external _swift_async_extendedFramePointerFlags (from libswift_Concurrency)
(undefined) weak external _swift_task_alloc (from libswift_Concurrency)
(undefined) weak external _swift_task_create (from libswift_Concurrency)
(undefined) weak external _swift_task_dealloc (from libswift_Concurrency)
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows applications that back-deploy but only use concurrency in
newer code to load and execute properly, even when the concurrency library
is not available. Fixes rdar://84877644.
Pair-programmed with @etcwilde