RequirementMachine: Implement -requirement-machine-protocol-signatures=verify #40011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pertyMap Now that the property map stores a reference to the RewriteSystem, defining the buildPropertyMap() method on PropertyMap feels cleaner, and allows more of the property map's internals to be private.
Using StartOffset to encode the prefix length is wrong, because then we get an invalid rewrite step after replaceRuleWithPath(). Instead, encode the prefix length in the RuleID field.
…Decompose When re-contextualizing a path containing RewriteStep::Decompose, don't update StartOffset/EndOffset for steps that execute with more than one term on the stack.
…uirementSignatureRequest This is a refactoring needed to implement 'verify' mode. The RequirementMachine computes the requirement signature for an entire connected component of protocols at once, whereas the GenericSignatureBuilder only does one protocol at a time. Using the same request for both in 'verify' mode meant that we would only call the GSB for the first protocol in a connected component, and then the RequirementMachine would fill in the rest. To fix this, split it up into two requests. The original RequirementSignatureRequest calls into the GSB, and then kicks off a RequirementSignatureRequestRQM to get the requirement signature computed by the RequirementMachine (possibly cached, if this protocol is part of a connected component with more than one protocol in it).
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and fix a couple of failures that came up. While we're getting closer, the stdlib still doesn't build; ArrayProtocol and StringProtocol are minimized incorrectly right now, because homotopy reduction don't model the property map's concrete type unification yet.