5.5 fix weak extended frame pointer flags #40044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
changed the title
The weakly-imported symbol was getting optimized out, then put back in as a strongly-imported symbol. This is no good. The symbol is a declaration though, so it can't be "used" directly. Instead, we assign it to another global and "use" it. That avoids the optimizations and should be fine. Even if that symbol is a nullptr because it doesn't exist, we are taking the pointer to it, which should be fine for all situations.
Make the little variable LinkOnceODRLinkage so that it doesn't take up as much space.
etcwilde
force-pushed
the
ewilde/5.5/fix-weak-extendedFramePointerFlags
branch
from
0865ced to
ffcbdc6
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test macOS |
|
Build failed |
|
MacOS failure is unrelated: |
This PR should fix the issue: |
|
@swift-ci please test macOS |
|
Thank you! |
angela-laar
approved these changes
Nov 11, 2021
DougGregor
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of: #40035
The weakly-imported symbol was getting optimized out, then put back in
as a strongly-imported symbol. This is no good. The symbol is a
declaration though, so it can't be "used" directly. Instead, we assign
it to another global and "use" it. That avoids the optimizations and
should be fine. Even if that symbol is a nullptr because it doesn't
exist, we are taking the pointer to it, which should be fine for all
situations.
Fixes rdar://84877644.