-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Module aliasing: allow getting real module names via ImportPath getters #40064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted a few nitpicks but overall the logic looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to talk me out of it, but I strongly suspect this should be implemented a little differently. Functionally, though, I think this is great other than the test quirks @xymus identified.
374f470
to
41c3d78
Compare
@swift-ci smoke test |
Resolves rdar://83632921, rdar://83633109
Modify ASTDumper to print module real names Add doc comments
Co-authored-by: Becca Royal-Gordon <[email protected]>
Co-authored-by: Becca Royal-Gordon <[email protected]>
Co-authored-by: Becca Royal-Gordon <[email protected]>
Co-authored-by: Becca Royal-Gordon <[email protected]>
Remove unnecessary setter Update tests
@swift-ci smoke test |
1 similar comment
@swift-ci smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have very, very minor comments on formatting and comment wording. (Some are mistakes in my previous suggestions—sorry about that.) These are all simple and mechanical, so I'm going to mark this "Approve" so that you don't need to ask for another review.
@swift-ci smoke test and merge |
-Set real module names in ImportDecl
-Add getRealImportPath / getRealModulePath
-Print real module names in ASTDumper
Resolves rdar://83632921, rdar://83633109