Skip to content

[NFC] Clean Up Unused Parameters in Unqualified Lookup #40069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Nov 5, 2021

  • Drop some unused parameters
  • const-qualify a consumption method that is logically const - though it
    isn't physically const given the mutating use in
    ASTScopeDeclConsumerForUnqualifiedLookup::lookInMembers
  • Privatize some internal fields

* Drop some unused fields
* const-qualify a consumption method that is logically const - though it
  isn't physically const given the mutating use in
  ASTScopeDeclConsumerForUnqualifiedLookup::lookInMembers
* Privatize some internal fields
@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 5, 2021

@swift-ci smoke test and merge

@CodaFi CodaFi changed the title [NFC] Clean Up Unused Fields in Unqualified Lookup [NFC] Clean Up Unused Parameters in Unqualified Lookup Nov 5, 2021
@CodaFi CodaFi merged commit f9aed0c into swiftlang:main Nov 6, 2021
@CodaFi CodaFi deleted the looking-around-with-my-feet-on-the-ground branch November 6, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant