[Reflection] Add API for inspecting async task allocation slabs. #40071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
eeckstein
approved these changes
Nov 9, 2021
| template <size_t SlabCapacity> | ||
| /// | ||
| /// SlabMetadataPtr specifies a fake metadata pointer to place at the beginning | ||
| /// of slaba llocations, so analysis tools can identify them. |
There was a problem hiding this comment.
Thanks, good catch.
mikeash
force-pushed
the
remote-mirror-async-slab-inspection
branch
from
831c1b6 to
7133a59
Compare
|
@swift-ci please test |
We remove the existing `swift_reflection_iterateAsyncTaskAllocations` API that attempts to provide all necessary information about a tasks's allocations starting from the task. Instead, we split it into two pieces: `swift_reflection_asyncTaskSlabPointer` to get the first slab for a task, and `+swift_reflection_asyncTaskSlabAllocations` to get the allocations in a slab, and a pointer to the next slab. We also add a dummy metadata pointer to the beginning of each slab. This allows tools to identify slab allocations on the heap without needing to locate every single async task object. They can then use `swift_reflection_asyncTaskSlabAllocations` on such allocations to find out about the contents. rdar://82549631
mikeash
force-pushed
the
remote-mirror-async-slab-inspection
branch
from
7133a59 to
7c7dc5d
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the existing
swift_reflection_iterateAsyncTaskAllocationsAPI that attempts to provide all necessary information about a tasks's allocations starting from the task. Instead, we split it into two pieces:swift_reflection_asyncTaskSlabPointerto get the first slab for a task, and+swift_reflection_asyncTaskSlabAllocationsto get the allocations in a slab, and a pointer to the next slab.We also add a dummy metadata pointer to the beginning of each slab. This allows tools to identify slab allocations on the heap without needing to locate every single async task object. They can then use
swift_reflection_asyncTaskSlabAllocationson such allocations to find out about the contents.rdar://82549631