Shims: strongly link swift_isStackAllocationSafe on !Darwin
#40075
Conversation
Windows objects to the multiple different aliases for `swift_isStackAllocationSafe`. Use strong linkage on all non-ABI stable targets. This should repair the Windows build and matches the conditional emission in the stdlib. Thanks to @lorentey for the discussion around how to handle this and the pointer to where this was getting introduced!
|
@swift-ci please test |
|
CC: @lorentey |
| SWIFT_RUNTIME_STDLIB_API | ||
| #if defined(__APPLE__) && defined(__MACH__) | ||
| SWIFT_WEAK_IMPORT | ||
| #endif |
There was a problem hiding this comment.
If this becomes a regular thing, then it may be a good idea to pull this out into a separate macro (SWIFT_RUNTIME_AVAILABLE_FUTURE or something like that).
Cc @mikeash Our intention is that once we have the OS version numbers corresponding to Swift 5.6, then this entry point will gain availability. For now, we need to arrange for this to be a weak symbol on Darwin, but strong elsewehere. (I think we may need to define regular availability macros too -- afaict we don't currently have those?)
(_swift_stdlib_getCurrentStackBounds below should probably have the same treatment, but it's only used in tests right now. Which reminds me that it may not even need to be exported. 🤔)
There was a problem hiding this comment.
It looks like the typical way to do this sort of thing is to redeclare the function in Swift with @_silgen_name and then stick the @available annotation on that.
|
Going to merge this for now to restore the Foundation build on Windows. |
Windows objects to the multiple different aliases for
swift_isStackAllocationSafe. Use strong linkage on all non-ABI stabletargets. This should repair the Windows build and matches the
conditional emission in the stdlib.
Thanks to @lorentey for the discussion around how to handle this and the
pointer to where this was getting introduced!
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.