[CodeCompletion] nil/[]/[:] default arguments are "interesting"
#40079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
func foo(arg: Int? = nil) Code completion didn't sugget 'foo()' call pattern variant for this function.
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Nov 9, 2021
| case DefaultArgumentKind::StoredProperty: | ||
| case DefaultArgumentKind::Inherited: // FIXME: include this? | ||
| return true; | ||
| default: |
There was a problem hiding this comment.
Nice. Hopefully this will help in the future :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code completion didn't suggest "without default argument" call pattern variant for functions with
nildefault arguments. e.g.This should suggest
foo(arg:)as well asfoo().rdar://85077605