Skip to content

[build-presets] Don't install sk-stress-test and swift-evolve into the nightly toolchains #40084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Nov 8, 2021

I don’t believe sk-stress-test and swift-evolve were used much and were adding ~20MB to the toolchain size. Let’s remove them.

rdar://85079653

@ahoppen ahoppen requested review from akyrtzi and shahmishal November 8, 2021 16:28
@ahoppen
Copy link
Member Author

ahoppen commented Nov 8, 2021

@swift-ci Please build toolchain

@ahoppen
Copy link
Member Author

ahoppen commented Nov 8, 2021

@swift-ci Please smoke test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 8, 2021

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 8a7cd4f0346678b3e37e887dc1d276c9581bf46e

Install command
tar zxf swift-PR-40084-728-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

swift-ci commented Nov 8, 2021

macOS Toolchain
Download Toolchain
Git Sha - 8a7cd4f0346678b3e37e887dc1d276c9581bf46e

Install command
tar -zxf swift-PR-40084-1212-osx.tar.gz --directory ~/

@ahoppen
Copy link
Member Author

ahoppen commented Nov 9, 2021

Verified that both the macOS and Linux toolchains don’t include sk-stress-test and swift-evolve.

@compnerd
Copy link
Member

compnerd commented Nov 9, 2021

@ahoppen - Windows does not either.

@@ -1273,8 +1273,6 @@ install-llbuild
install-swiftpm
install-swift-driver
install-swiftsyntax
install-skstresstester
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also not build it if we are not installing it?

skstresstester
swiftevolve

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes that makes sense. I was thinking that we should still build the projects in CI to make sure they don’t break but of course that’s already covered by other presets.

…e nightly toolchains

I don’t believe sk-stress-test and swift-evolve were used much and were adding ~20MB to the toolchain size. Let’s remove them.

rdar://85079653
@ahoppen ahoppen force-pushed the pr/dont-install-stress-tester branch from 8a7cd4f to a50b4a9 Compare November 15, 2021 10:08
@ahoppen
Copy link
Member Author

ahoppen commented Nov 15, 2021

@swift-ci Please smoke test

@ahoppen
Copy link
Member Author

ahoppen commented Nov 15, 2021

@swift-ci Please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - a50b4a9

Install command
tar zxf swift-PR-40084-730-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - a50b4a9

Install command
tar -zxf swift-PR-40084-1216-osx.tar.gz --directory ~/

@ahoppen ahoppen merged commit 893bb06 into swiftlang:main Nov 16, 2021
@ahoppen ahoppen deleted the pr/dont-install-stress-tester branch November 16, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants