-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[build-presets] Don't install sk-stress-test and swift-evolve into the nightly toolchains #40084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please build toolchain |
@swift-ci Please smoke test |
Linux Toolchain (Ubuntu 16.04) Install command |
macOS Toolchain Install command |
Verified that both the macOS and Linux toolchains don’t include |
@ahoppen - Windows does not either. |
@@ -1273,8 +1273,6 @@ install-llbuild | |||
install-swiftpm | |||
install-swift-driver | |||
install-swiftsyntax | |||
install-skstresstester |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also not build it if we are not installing it?
skstresstester
swiftevolve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes that makes sense. I was thinking that we should still build the projects in CI to make sure they don’t break but of course that’s already covered by other presets.
…e nightly toolchains I don’t believe sk-stress-test and swift-evolve were used much and were adding ~20MB to the toolchain size. Let’s remove them. rdar://85079653
8a7cd4f
to
a50b4a9
Compare
@swift-ci Please smoke test |
@swift-ci Please build toolchain |
Linux Toolchain (Ubuntu 16.04) Install command |
macOS Toolchain Install command |
I don’t believe sk-stress-test and swift-evolve were used much and were adding ~20MB to the toolchain size. Let’s remove them.
rdar://85079653